Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beeper.io is no more #1808

Merged
merged 3 commits into from
Nov 27, 2016
Merged

Beeper.io is no more #1808

merged 3 commits into from
Nov 27, 2016

Conversation

cantino
Copy link
Member

@cantino cantino commented Nov 20, 2016

Fix #1762

@knu
Copy link
Member

knu commented Nov 21, 2016

Would having instances of a deleted agent cause any problem?

@virtadpt
Copy link
Collaborator

I blew mine away, just in case.

@cantino
Copy link
Member Author

cantino commented Nov 21, 2016

I checked and the UI knows how to handle a missing Agent. I'll check and make sure that propagation doesn't error out.

@cantino
Copy link
Member Author

cantino commented Nov 24, 2016

@knu I've added code to avoid propagating or checking on missing agents.

knu
knu approved these changes Nov 27, 2016
View reviewed changes
Copy link
Member

@knu knu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Maybe we could update the instructions in the "Error: Agent(s) are 'missing in action'" page to let user know that the Agent type might have deleted, possibly with a link to a new Wiki page that lists retired Agents.

@cantino
Copy link
Member Author

cantino commented Nov 27, 2016

Done, good idea.

@cantino cantino merged commit 8a14a57 into master Nov 27, 2016
@cantino cantino deleted the remove_beeper_agent branch November 27, 2016 20:30
strugee pushed a commit to strugee/huginn that referenced this pull request Dec 23, 2016
@cantino @strugee
Beeper.io is no more (huginn#1808)
964815b 
* Beeper.io is no more

* Avoid event propagation or scheduling of missing agents

* Update undefined_agents.html.erb with a link to the wiki
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knu knu knu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cantino @knu @virtadpt